From ad267faa48f0f41ffdebb73dda261eb29b61b97c Mon Sep 17 00:00:00 2001
From: GNajeral <90567992+GNajeral@users.noreply.github.com>
Date: Thu, 13 Apr 2023 18:50:16 +0200
Subject: [PATCH] Updated categorical and binary too for local script

---
 valid_variables_script_local.R | 58 +++++++++++++++++++---------------
 1 file changed, 32 insertions(+), 26 deletions(-)

diff --git a/valid_variables_script_local.R b/valid_variables_script_local.R
index 9afd01e..62ff7b0 100644
--- a/valid_variables_script_local.R
+++ b/valid_variables_script_local.R
@@ -138,12 +138,6 @@ check_valid_name <- function(col_name){
      
      last <- names(failing_value_counts)[length(failing_value_counts)]
      
-     print(colname)
-     print("first")
-     print(first)
-     print("last")
-     print(last)
-     
      str_res <- paste(str_res, "Values lie in the range:", paste("[", first, " - ",last, "]", sep = "" ))
      
      
@@ -194,17 +188,29 @@ check_valid_name <- function(col_name){
      range_as_str <- paste(min_value, "-", max_value, " (categorical)")
      failing_values <- failing_values[!is.na(failing_values)]
      failing_value_counts <- table(failing_values)
+     
+     str_res <- paste(colname, "has wrong values:")
+     
+     str_res <- paste(str_res, paste(number_of_failing_values, ",", sep = ""))
+     
+     str_res <- paste(str_res, "should be in the range:", paste(min_value, max_value, sep = "-"), "(categorical),", sep = " ")
+     
+     first <- names(failing_value_counts)[1]
+     
+     last <- names(failing_value_counts)[length(failing_value_counts)]
+     
+     str_res <- paste(str_res, "Values lie in the range:", paste("[", first, " - ",last, "]", sep = "" ))
 
-     str_res <- paste(colname, "has failing values:")
-
-     for (i in seq_along(failing_value_counts)) {
-       value <- names(failing_value_counts)[i]
-       count <- failing_value_counts[i]
-       str_res <- paste(str_res, paste(value, "(", count, "times)", collapse = " "), sep = " ")
-     }
-
-     str_res <- paste(str_res, "should be in range", range_as_str, sep = " ")
-   }
+   #   str_res <- paste(colname, "has failing values:")
+   # 
+   #   for (i in seq_along(failing_value_counts)) {
+   #     value <- names(failing_value_counts)[i]
+   #     count <- failing_value_counts[i]
+   #     str_res <- paste(str_res, paste(value, "(", count, "times)", collapse = " "), sep = " ")
+   #   }
+   # 
+   #   str_res <- paste(str_res, "should be in range", range_as_str, sep = " ")
+   # }
 
    return(str_res)
  }
@@ -222,16 +228,16 @@ check_valid_name <- function(col_name){
      failing_values <- failing_values[!is.na(failing_values)]
      failing_value_counts <- table(failing_values)
 
-     str_res <- paste(colname, "has failing values:")
-
-     for (i in seq_along(failing_value_counts)) {
-       value <- names(failing_value_counts)[i]
-       count <- failing_value_counts[i]
-       str_res <- paste(str_res, paste(value, "(", count, "times)", collapse = " "), sep = " ")
-     }
-
-     str_res <- paste(str_res, "should be in range", range_as_str, sep = " ")
-   }
+   #   str_res <- paste(colname, "has failing values:")
+   # 
+   #   for (i in seq_along(failing_value_counts)) {
+   #     value <- names(failing_value_counts)[i]
+   #     count <- failing_value_counts[i]
+   #     str_res <- paste(str_res, paste(value, "(", count, "times)", collapse = " "), sep = " ")
+   #   }
+   # 
+   #   str_res <- paste(str_res, "should be in range", range_as_str, sep = " ")
+    }
 
    return(str_res)
  }
-- 
2.24.1